Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Impersonate class for minor performance checks on each run/per row #86

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Update Impersonate class for minor performance checks on each run/per row #86

merged 1 commit into from
Jun 17, 2021

Conversation

BinaryKitten
Copy link
Contributor

Update Impersonate.php

  • use $authUser variable to reduce call depth
  • add more strict null check
  • remove the additional check for type when numeric or string

@BinaryKitten
Update Impersonate.php
cd5847c 
- use $authUser variable to remove call depth
- add more strict null check
- remove the additional check for type when numeric or string
@KABBOUCHI KABBOUCHI merged commit e5aab84 into KABBOUCHI:master Jun 17, 2021
@BinaryKitten BinaryKitten deleted the fix/remove_superfluous_check branch June 17, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BinaryKitten @KABBOUCHI